[ODP-2600] ODIL Enhancement’s Billing Indicator & Line Split Created: 17/Dec/21  Updated: 03/Apr/22  Resolved: 22/Mar/22

Status: Waiting for Deployment
Project: OD Product
Component/s: None
Affects Version/s: None
Fix Version/s: 2.60, Neuro.1.3.0

Type: Feature Priority: Medium
Reporter: Panagiotis Theodoropoulos Assignee: Panagiotis Konidis
Resolution: Done Votes: 0
Labels: Thinkrit
Σ Remaining Estimate: 2 days Remaining Estimate: Not Specified
Σ Time Spent: 6 hours, 45 minutes Time Spent: 5 hours
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: Microsoft Word FDD-ODP-2600-BillingIndicators_SplitLines.docx     Microsoft Word FDD-ODP-2600-BillingIndicators_SplitLines_v2.docx     Microsoft Word FDD-ODP-2600-BillingIndicators_SplitLines_v3.docx     File ILJobLineComponentModel.json    
Issue Links:
Relates
relates to ODP-3499 TC and Test ODP-2600 Open
relates to ODP-3703 TC and Test ODP-2600 Open
Sub-Tasks:
Key
 Summary
 Type
 Status
 Assignee
ODP-2601 Effort Estimation for ODP-2600 Sub-task Done  
ODP-3466 Enhance JobCardManager Sub-task Done Panagiotis Konidis  
ODP-3467 Add mapping types and providers for B... Sub-task Done Panagiotis Konidis  
Tenant:
Product
Epic Link: DASW Product Features Release 2.0
Business Unit:
DASW
Escalate: No
FRD Handover Date:
Unplanned Remaining Estimate: 0
For Team Discussion: No
Resolution Details: Billing Indicator must be tested with an involved customer in order toidentify any gaps/bugs throughout the whole integration process.

At the moment, what could be done is to create a jobcard with split lines and billing indicators set, in order to check in the InterfacingRequestLogs that everything is fine.
Target Version:
Scope:
DASW Product Completion
Attachment_Name: FDD-ODP-2600-BillingIndicators_SplitLines.docx, FDD-ODP-2600-BillingIndicators_SplitLines_v2.docx, FDD-ODP-2600-BillingIndicators_SplitLines_v3.docx, ILJobLineComponentModel.json

 Description   

Need to enhance the ODIL and include the billing indicators as well as the line split

 Comments   
Comment by Alexandridis Lazaros [ 28/Jan/22 ]

Hello Panagiotis Konidis is this in progress?

Comment by Panagiotis Konidis [ 08/Mar/22 ]

Panagiotis Theodoropoulos

 

Hi Panos

  1. Is the Billing Indicator Type (OptionField Configuration) a mapping Type?  Should it be mapped to DMS Values
  2. Is it true that the Billing Indicator Codeis a set of standard values (Enumeration object) that can contain only the values below:
    1. Warranty
    2. Internal
    3. Customer

 

FYI. Bompetsis Evangelos Christian Hoell

Comment by Panagiotis Konidis [ 09/Mar/22 ]

FDD Is completed please review it Panagiotis Theodoropoulos.

Comment by Panagiotis Konidis [ 15/Mar/22 ]

FDD Is Updated, Developments have been analyzed and done. 

Panagiotis Theodoropoulos PLease apprive the FDD or comment for any amendments

Testing with ODIL is Pending

Comment by Panagiotis Theodoropoulos [ 15/Mar/22 ]

Hi Panos [Panagiotis Konidis]

All good from my side

 

Br, Panagiotis

 

Comment by Panagiotis Konidis [ 15/Mar/22 ]

According to Panos both:

  1. BillingIndicatorType and 
  2. BillingIndicatorCode 

Should be static mapping types as dome DMS values may differ from our static ENUM codes (for BillingIndicatorCodes in particular)

Thus, FDD is updated and is up to ODIL now for implementation. 

 

FYI. Bompetsis Evangelos

Comment by odil (thinkrit) [ 17/Mar/22 ]

Changes are implemented.




[ODP-3752] Fix VAT Amount Calulcations on IL jobCardModel Created: 06/Apr/22  Updated: 06/Apr/22  Resolved: 06/Apr/22

Status: Done
Project: OD Product
Component/s: None
Affects Version/s: None
Fix Version/s: 2.60, 2.61, Neuro.1.3.0, 2.58.20

Type: Task Priority: SIT/UAT Blocker
Reporter: Panagiotis Konidis Assignee: Panagiotis Konidis
Resolution: Done Votes: 0
Labels: Thinkrit
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Escalate: No
Unplanned Remaining Estimate: 0
For Team Discussion: No
Resolution Details: Done already on 2.58. Please Create a JobCard and Check the VAT Amounts (with and wuithout discounts applied on JobLineComponents) in jobCardLines created by out IntegrationLayer module
Specification Status: 1. Not Planned

 Description   

HYUNDAI Go-Live Relevant

 Comments   
Comment by Panagiotis Konidis [ 06/Apr/22 ]

Add  ClosedDate  on JobCardModel

Fix logc on VATAmount Calculations.




Add the Closing Date to the Job Card API (ODP-3756)

[ODP-3758] ODIL - Add ClosedDate on JobCard Model Created: 06/Apr/22  Updated: 07/Apr/22  Resolved: 07/Apr/22

Status: Done
Project: OD Product
Component/s: None
Affects Version/s: None
Fix Version/s: 2.60, 2.61, Neuro.1.3.0, 2.58.21

Type: Sub-task Priority: Critical
Reporter: Panagiotis Konidis Assignee: Panagiotis Konidis
Resolution: Done Votes: 0
Labels: Thinkrit
Remaining Estimate: 0 minutes
Time Spent: 15 minutes
Original Estimate: Not Specified

Escalate: No
Unplanned Remaining Estimate: 0
For Team Discussion: No
Resolution Details: Properties added.

Create new jobcard. Move the WF steps in order to close it. Check mongo logs if closedDates are introduced in the payloads sent to ODIL
Specification Status: 1. Not Planned

 Description   
  • Add property ClosedDate (DateTime) on Jobcard

 Comments   
Comment by Panagiotis Konidis [ 06/Apr/22 ]

odil (thinkrit) hello I can see it already in our OD-ODIL-API 1.3.0 is it done already?

 

Comment by odil (thinkrit) [ 07/Apr/22 ]

Hi Pano,

it is now complete.

BR,




[AVSB-330] ODIL - Add DMS Codes for Contact persons and Business Partners Created: 06/Apr/22  Updated: 08/Apr/22  Resolved: 08/Apr/22

Status: Done
Project: AVAG Pilot Sieber
Component/s: None
Affects Version/s: None
Fix Version/s: 2.59, 2.60, 2.61, 2.58.21

Type: Task Priority: Medium
Reporter: Panagiotis Konidis Assignee: Panagiotis Konidis
Resolution: Done Votes: 0
Labels: Thinkrit
Remaining Estimate: 3 hours
Time Spent: 1 hour
Original Estimate: 4 hours

Issue Links:
Relates
relates to AVSB-326 Populate DMS Codes or BP/CP/Vehicle t... Done
Business Unit:
Interfaces
Escalate: No
Unplanned Remaining Estimate: 3
For Team Discussion: No
Resolution Details: 1. Create or Update a BP or CP and
2. Please test on payloads requested or received by ODIL if the new fields are included in the sent payloads.

Specification Status: 1. Not Planned

 Description   

Add composite keys for the Contact persons and Business Partners models that pass through ODIL.

The DMS Codes are crucial for the respective entity referencing needs of the LH Campaign manager. 

Additional changes will be needed  by ODIL (enhance models with composite keys)

 Comments   
Comment by Panagiotis Konidis [ 06/Apr/22 ]

DSW Change: Changeset 55093

 

Hi odil (thinkrit) Please add in theCP/BP Composite Code Models for the respective entities so that the DMS Codes are propagated between the end systems  DSW <> DMS.

 

A. In the BusinessPartnerDto add property 

Name: BusinessPartnerCode

Type: CompositeCodeModel 

 

B. In the CustomerDto add property 

Name: ContactPersonCode

Type: CompositeCodeModel 

 

Of course the previous BPCode and CPCode properties remain in the schemas of the payload to ensure backwards compatibility.

 

 

 

Comment by odil (thinkrit) [ 07/Apr/22 ]

Development is finished

Comment by Panagiotis Konidis [ 08/Apr/22 ]

Done by ODIL. 

 

 




Generated at Fri Apr 08 07:04:48 UTC 2022 by Panagiotis Konidis using Jira 8.5.19#805019-sha1:9436cab740de148c15a2efcd2644cfe9bc07cac2.